Messages in this thread | | | Date | Tue, 22 Feb 2011 02:34:52 +0000 | From | Mark Brown <> | Subject | Re: [rtc-linux] [PATCH 04/10] RTC: Cleanup rtc_class_ops->read_alarm() |
| |
On Mon, Feb 21, 2011 at 03:55:32PM -0800, John Stultz wrote: > With the generic rtc code managing the now virtualized alarm timer, > no one actually calls rtc_clas_ops->read_alarm().
> We do check that it exists in rtc_read_alarm(), but that is only > to verify that the hardware supports irqs. The same test can > be done by checking set_alarm instead.
> This patch changes the the read_alarm check to set_alarm, and then > removes the read_alarm method and its implementations in the rt > drivers.
Can you go into more detail on the rationale behind this virtualised functionality and how it works? I'd really expect the RTC alarm to be preserved over system reboots (on some systems it can be used to initiate a boot) and that would mean that we need to go to the hardware for at least the initial configuration.
| |