Messages in this thread | | | Subject | Re: [PATCH 5/5] sched, autogroup: runtime enable/disable tuning fix | From | Mike Galbraith <> | Date | Mon, 21 Feb 2011 04:13:25 +0100 |
| |
On Sun, 2011-02-20 at 18:22 +0100, Mike Galbraith wrote: > On Sun, 2011-02-20 at 22:10 +0800, Yong Zhang wrote: > > On Sun, Feb 20, 2011 at 02:09:39PM +0100, Mike Galbraith wrote: > > > On Sun, 2011-02-20 at 15:08 +0800, Yong Zhang wrote: > > > > Now enable/disable autogroup at runtime is just a flag, > > > > it doesn't take effect on current process of the system. > > > > > > Yup, they only move upon migration, which can take up to forever. > > > > Yeah. so on UP, the user can have autogroup forever or not, and > > sched_autogroup_enable is a nop. > > Yup, and that's the best argument for doing the active switch. > > > Apart from runtime enable/disable issue, I think patch1~3 could > > still be applied beause they really fix some problem or bring > > some improvement. > > Yeah. > > Your whole series looked fine to me at a glance (sunday;), with the > exception of #2, that one is maybe iffy, depending on point of view.
Hm, my mind wandered off to different file somewhere along the line :)
-Mike
| |