Messages in this thread | | | Date | Mon, 21 Feb 2011 17:05:33 +0800 | Subject | Re: [PATCH 5/5] sched, autogroup: runtime enable/disable tuning fix | From | Yong Zhang <> |
| |
On Mon, Feb 21, 2011 at 11:13 AM, Mike Galbraith <efault@gmx.de> wrote: >> Your whole series looked fine to me at a glance (sunday;), with the >> exception of #2, that one is maybe iffy, depending on point of view. > > Hm, my mind wandered off to different file somewhere along the line :)
Never mind :)
If we relax the runtime autogroup switch, maybe patch-2 is a little overkill, because after autogroup is disabled there still could have some tasks staying on it's autogroup. So if we wan to keep current autogroup switch behavior, I think we can make autogroup_path() independent on sysctl_sched_autogroup_enabled, thus user will not be confused by lots of groups named "cfs_rq[*]:"
But if this patch is accepted, IMHO, patch-2 is ok.
Thanks, Yong
-- Only stand for myself
| |