Messages in this thread | | | Date | Fri, 18 Feb 2011 11:39:36 -0800 (PST) | Subject | Re: [PATCH v2] net: provide default_advmss() methods to blackhole dst_ops | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Fri, 18 Feb 2011 14:44:32 +0100
> Le vendredi 18 février 2011 à 14:33 +0100, Eric Dumazet a écrit : > >> I had this exact idea but found we need struct net pointer to get this >> value, not provided in parameters, so I falled back to the 256 value. >> >> > > Hmm, reading again this stuff, maybe we can just use > ipv4_default_advmss() instead of a custom one. > > dst->dev should be available > > [PATCH] net: provide default_advmss() methods to blackhole dst_ops > > Commit 0dbaee3b37e118a (net: Abstract default ADVMSS behind an > accessor.) introduced a possible crash in tcp_connect_init(), when > dst->default_advmss() is called from dst_metric_advmss() > > Reported-by: George Spelvin <linux@horizon.com> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Yes, this is a lot better, applied.
Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |