Messages in this thread | | | Subject | Re: [PATCH] net: Add default_advmss() methods to blackhole dst_ops | From | Eric Dumazet <> | Date | Fri, 18 Feb 2011 14:33:25 +0100 |
| |
Le vendredi 18 février 2011 à 21:29 +0800, Changli Gao a écrit : > On Fri, Feb 18, 2011 at 9:24 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > > Le vendredi 18 février 2011 à 21:16 +0800, Changli Gao a écrit : > > > >> I am wondering why magic number 256 is used here. Is there a special > >> reason? Thanks. > >> > > > > It really doesnt matter. SYN message will be dropped anyway. > > > > 256 happens to be the default value > > of /proc/sys/net/ipv4/route/min_adv_mss > > > > Thanks for your explaining. IMHO, ip_rt_min_advmss is better than a > magic number, here. >
I had this exact idea but found we need struct net pointer to get this value, not provided in parameters, so I falled back to the 256 value.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |