Messages in this thread Patch in this message | | | Date | Fri, 18 Feb 2011 10:38:24 GMT | From | tip-bot for Arnaldo Carvalho de Melo <> | Subject | [tip:perf/core] perf report: Tell the user when a perf.data file has no samples |
| |
Commit-ID: 74cfc17dc1a69c37ce6c8a76c1ce84bcb796eb0e Gitweb: http://git.kernel.org/tip/74cfc17dc1a69c37ce6c8a76c1ce84bcb796eb0e Author: Arnaldo Carvalho de Melo <acme@redhat.com> AuthorDate: Thu, 17 Feb 2011 14:40:46 -0200 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 17 Feb 2011 14:40:46 -0200
perf report: Tell the user when a perf.data file has no samples
[root@emilia ~]# perf report --stdio The perf.data file has no samples! [root@emilia ~]#
The TUI shows a popup warning message with the same message.
Reported-by: Ingo Molnar <mingo@elte.hu> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tom Zanussi <tzanussi@gmail.com> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-report.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index f9a99a1..dddcc7e 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -350,6 +350,12 @@ static int __cmd_report(void) perf_session__fprintf_dsos(session, stdout); next = rb_first(&session->hists_tree); + + if (next == NULL) { + ui__warning("The %s file has no samples!\n", input_name); + goto out_delete; + } + while (next) { struct hists *hists;
| |