lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] bluethooth: sco: fix information leak to userspace
    Date
    struct sco_conninfo has one padding byte in the end.  Local variable
    cinfo of type sco_conninfo is copied to userspace with this uninizialized
    one byte, leading to old stack contents leak.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    ---
    Compile tested.

    net/bluetooth/sco.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
    index 960c6d1..926ed39 100644
    --- a/net/bluetooth/sco.c
    +++ b/net/bluetooth/sco.c
    @@ -703,6 +703,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user
    break;
    }

    + memset(&cinfo, 0, sizeof(cinfo));
    cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle;
    memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);

    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-02-14 11:57    [W:0.022 / U:29.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site