| From | Andi Kleen <> | Subject | [PATCH] [82/139] inotify: stop kernel memory leak on file creation failure | Date | Tue, 1 Feb 2011 16:44:39 -0800 (PST) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Eric Paris <eparis@redhat.com>
commit a2ae4cc9a16e211c8a128ba10d22a85431f093ab upstream.
If inotify_init is unable to allocate a new file for the new inotify group we leak the new group. This patch drops the reference on the group on file allocation failure.
Reported-by: Vegard Nossum <vegard.nossum@gmail.com> Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Andi Kleen <ak@linux.intel.com>
--- fs/notify/inotify/inotify_user.c | 1 + 1 file changed, 1 insertion(+)
Index: linux-2.6.35.y/fs/notify/inotify/inotify_user.c =================================================================== --- linux-2.6.35.y.orig/fs/notify/inotify/inotify_user.c +++ linux-2.6.35.y/fs/notify/inotify/inotify_user.c @@ -674,6 +674,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flag if (ret >= 0) return ret; + fsnotify_put_group(group); atomic_dec(&user->inotify_devs); out_free_uid: free_uid(user);
|