[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] [107/139] gpio: Fix null pointer dereference while accessing rdc321x platform_data
2.6.35-longterm review patch.  If anyone has any objections, please let me know.

From: Florian Fainelli <>

commit fa6469cb5b2d16703464c344b943e2c025cb7858 upstream.

rdc321x-gpio currently fetches its driver specific data by using the
platform_device->platform_data pointer, this is wrong because the mfd
device which registers our platform_device has been added using
mfd_add_device() which sets the platform_device->driver_data pointer

Signed-off-by: Florian Fainelli <>
Signed-off-by: Samuel Ortiz <>
Signed-off-by: Greg Kroah-Hartman <>
Signed-off-by: Andi Kleen <>

drivers/gpio/rdc321x-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.35.y/drivers/gpio/rdc321x-gpio.c
--- linux-2.6.35.y.orig/drivers/gpio/rdc321x-gpio.c
+++ linux-2.6.35.y/drivers/gpio/rdc321x-gpio.c
@@ -135,7 +135,7 @@ static int __devinit rdc321x_gpio_probe(
struct rdc321x_gpio *rdc321x_gpio_dev;
struct rdc321x_gpio_pdata *pdata;

- pdata = pdev->dev.platform_data;
+ pdata = platform_get_drvdata(pdev);
if (!pdata) {
dev_err(&pdev->dev, "no platform data supplied\n");
return -ENODEV;

 \ /
  Last update: 2011-02-02 01:55    [from the cache]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site