lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectChange DECOMPRESS_LZMA to boolean
From
On Sun, 03 Jan 2010 00:55:55 +0000 Phillip Lougher wrote:
> Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > When CONFIG_SQUASHFS=m and CONFIG_DECOMPRESS_LZMA=m, decompress_lzma
> > is built but then discarded from the library because no built-in code
> > uses it, so change it from a lib- to an obj- to force it to be kept
> > in the library.
> >
> > ERROR: "unlzma" [fs/squashfs/squashfs.ko] undefined!
> >
>
> Thanks for fixing this, I should have spotted it in my various
> config tests but didn't. I could add this to my squashfs-next patches
> to stop the linux-next tree breakage, however, should it go into
> Michal's kbuild -next tree instead?
>
> This patch raises a small additional issue, why is DECOMPRESS_LZMA
> (and DECOMPRESS_GZIP/DECOMPRESS_BZIP2) and defined as tristate?
> None of the above compressors can be built as modules.

I just ran into this exact same issue, when disabling DEV_BLK_INITRD
and setting SQUASHFS to "m" and selecting SQUASHFS_LZMA. The option
then evaluates to:

DECOMPRESS_LZMA [=m]
Selected by: RD_LZMA [=n] && BLK_DEV_INITRD [=n] ||
SQUASHFS_LZMA [=y] && MISC_FILESYSTEMS [=y] && SQUASHFS [=m]

With these settings the linker complains:

Error: "unlzma" [fs/squashfs/squashfs.ko] undefined

Please change DECOMPRESS_LZMA (and perhaps the other DECOMPRESS_*
symbols) to boolean.

Regards,
Marcel


\
 
 \ /
  Last update: 2011-02-02 00:29    [W:0.015 / U:9.644 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site