lkml.org 
[lkml]   [2011]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64_t
On Thu, 22 Dec 2011 00:55:07 +0100
Andreas Schwab <schwab@linux-m68k.org> wrote:

> Andrew Morton <akpm@linux-foundation.org> writes:
>
> > Also, in include/asm-generic/cputime.h we have:
> >
> > #define usecs_to_cputime64(__msecs) nsecs_to_jiffies64((__msecs) * 1000)
> >
> > But it would be neater to have used nsecs_to_cputime64(), surely.
>
> The procfs interface wants to convert usecs to cputime64, but generic
> cputime does not have usecs_to_jiffies64. Once someone writes the
> latter it can be used here.
>

That doesn't address my suggestion.

I'm saying that this:

#define usecs_to_cputime64(__msecs) nsecs_to_jiffies64((__msecs) * 1000)

should have instead been

#define usecs_to_cputime64(__msecs) nsecs_to_cputime64((__msecs) * 1000)



\
 
 \ /
  Last update: 2011-12-22 01:01    [W:0.072 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site