lkml.org 
[lkml]   [2011]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64_t
Date
Andrew Morton <akpm@linux-foundation.org> writes:

> On Thu, 22 Dec 2011 00:50:06 +0100
> Andreas Schwab <schwab@linux-m68k.org> wrote:
>
>> Andrew Morton <akpm@linux-foundation.org> writes:
>>
>> > From: Andreas Schwab <schwab@linux-m68k.org>
>> > Subject: procfs: do not confuse jiffies with cputime64_t
>> >
>> > get_{idle,iowait}_time are supposed to return cputime64_t values, not
>> > jiffies. Add usecs_to_cputime64 for this.
>>
>> For most architectures (which use the asm-generic/cputime.h) jiffies use
>> the same unit as cputime64_t values, but ia64, powerpc and s390 make
>> them different.
>>
>
> OK, but
>
> a) what effect does this problem have upon users of the kernel?

get_idle_time returns the value in the wrong unit.

> b) which kernel version(s) are affected?

get_idle_time got broken in 2a95ea6c0d129b4568fb64e1deda16ceb20e6636.

$ git tag --contains a25cac5198d4ff2842ccca63b423962848ad24b2
v3.2-rc1
v3.2-rc2
v3.2-rc3
v3.2-rc4
v3.2-rc5
v3.2-rc6

Andreas.

--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."


\
 
 \ /
  Last update: 2011-12-22 01:17    [from the cache]
©2003-2011 Jasper Spaans