Messages in this thread | | | Subject | Re: [PATCH] vmalloc: remove #ifdef in function body | Date | Wed, 21 Dec 2011 07:13:49 +0100 | From | "Michal Nazarewicz" <> |
| |
On Wed, 21 Dec 2011 06:17:59 +0100, Minchan Kim <minchan@kernel.org> wrote: > We don't like function body which include #ifdef. > If we can, define null function to go out compile time. > It's trivial, no functional change.
It actually adds “flush_tlb_kenel_range()” call to the function so there is functional change.
> Signed-off-by: Minchan Kim <minchan@kernel.org> > --- > mm/vmalloc.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 0aca3ce..e1fa5a6 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -505,6 +505,7 @@ static void unmap_vmap_area(struct vmap_area *va) > vunmap_page_range(va->va_start, va->va_end); > } >+#ifdef CONFIG_DEBUG_PAGEALLOC > static void vmap_debug_free_range(unsigned long start, unsigned long end) > { > /* > @@ -520,11 +521,15 @@ static void vmap_debug_free_range(unsigned long start, unsigned long end) > * debugging doesn't do a broadcast TLB flush so it is a lot > * faster). > */ > -#ifdef CONFIG_DEBUG_PAGEALLOC > vunmap_page_range(start, end); > flush_tlb_kernel_range(start, end); > -#endif > } > +#else > +static inline void vmap_debug_free_range(unsigned long start, > + unsigned long end) > +{ > +} > +#endif > /* > * lazy_max_pages is the maximum amount of virtual address space we gather up
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |