lkml.org 
[lkml]   [2011]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vmalloc: remove #ifdef in function body
On Tue, Dec 20, 2011 at 09:58:19PM -0800, Joe Perches wrote:
> On Wed, 2011-12-21 at 14:45 +0900, Minchan Kim wrote:
> > On Tue, Dec 20, 2011 at 09:31:21PM -0800, Joe Perches wrote:
> > > On Wed, 2011-12-21 at 14:17 +0900, Minchan Kim wrote:
> > > > We don't like function body which include #ifdef.
> []
> > > I don't like this change.
> > > I think it's perfectly good style to use:
> > I feel it's no problem as it is because it's very short function now
> > but it's not style we prefer.
>
> Who is this "we" you refer to?
>
> There's nothing suggesting your patch as a preferred style
> in Documentation/CodingStyle.

Yes. It doesn't have.
But I have thought we have done until now.
I think we can see them easily.

#> grep -nRH 'static inline void' ./ | grep {} | wc -l
936
If we consider line which don't include brace in one line, it would be many.

>
> cheers, Joe
>

--
Kind regards,
Minchan Kim


\
 
 \ /
  Last update: 2011-12-21 07:09    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean