lkml.org 
[lkml]   [2011]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/10] crypto: Add support for x86 cpuid auto loading for x86 crypto drivers
On 12/19/2011 03:22 PM, Dave Jones wrote:
> On Mon, Dec 19, 2011 at 02:47:39PM -0800, Andi Kleen wrote:
>
> > static int __init padlock_init(void)
> > {
> > int rc = -ENODEV;
> > @@ -533,15 +540,8 @@ static int __init padlock_init(void)
> > struct shash_alg *sha1;
> > struct shash_alg *sha256;
> >
> > - if (!cpu_has_phe) {
> > - printk(KERN_NOTICE PFX "VIA PadLock Hash Engine not detected.\n");
> > - return -ENODEV;
> > - }
> > -
> > - if (!cpu_has_phe_enabled) {
> > - printk(KERN_NOTICE PFX "VIA PadLock detected, but not enabled. Hmm, strange...\n");
> > + if (!x86_match_cpu(padlock_sha_ids) || !cpu_has_phe_enabled)
> > return -ENODEV;
> > - }
>
> don't we want to keep the printk ?
>
> Seems that if it's been disabled by the BIOS for some reason, it will now
> silently fail instead of printing a nice warning.
>

The first printk is insanely annoying, because the end result is that we
get a printk of all the crypto engines that are *not* enabled...
arguably it would be somewhat nice to get a printk when a crypto engine
*is* enabled.

-hpa



\
 
 \ /
  Last update: 2011-12-20 00:27    [W:0.179 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site