lkml.org 
[lkml]   [2011]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/10] crypto: Add support for x86 cpuid auto loading for x86 crypto drivers
    On Mon, Dec 19, 2011 at 02:47:39PM -0800, Andi Kleen wrote:

    > static int __init padlock_init(void)
    > {
    > int rc = -ENODEV;
    > @@ -533,15 +540,8 @@ static int __init padlock_init(void)
    > struct shash_alg *sha1;
    > struct shash_alg *sha256;
    >
    > - if (!cpu_has_phe) {
    > - printk(KERN_NOTICE PFX "VIA PadLock Hash Engine not detected.\n");
    > - return -ENODEV;
    > - }
    > -
    > - if (!cpu_has_phe_enabled) {
    > - printk(KERN_NOTICE PFX "VIA PadLock detected, but not enabled. Hmm, strange...\n");
    > + if (!x86_match_cpu(padlock_sha_ids) || !cpu_has_phe_enabled)
    > return -ENODEV;
    > - }

    don't we want to keep the printk ?

    Seems that if it's been disabled by the BIOS for some reason, it will now
    silently fail instead of printing a nice warning.

    Dave



    \
     
     \ /
      Last update: 2011-12-20 00:25    [W:0.023 / U:2.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site