lkml.org 
[lkml]   [2011]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Put braces around potentially empty 'if' body in handle_pte_fault()
If one builds the kernel with -Wempty-body one gets this warning:

mm/memory.c:3432:46: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that
can sometimes be defined to nothing.

I suggest we heed gcc's advice and put a pair of braces on that if.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
mm/memory.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index 829d437..9cf1b48 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3428,9 +3428,9 @@ int handle_pte_fault(struct mm_struct *mm,
* This still avoids useless tlb flushes for .text page faults
* with threads.
*/
- if (flags & FAULT_FLAG_WRITE)
+ if (flags & FAULT_FLAG_WRITE) {
flush_tlb_fix_spurious_fault(vma, address);
+ }
}
unlock:
pte_unmap_unlock(pte, ptl);
--
1.7.8
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
\
 
 \ /
  Last update: 2011-12-18 01:05    [W:0.056 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site