Messages in this thread | | | Date | Tue, 13 Dec 2011 09:50:41 +0000 | From | Jamie Iles <> | Subject | Re: drivers/crypto/picoxcell_crypto.c: boolean and / or confusion |
| |
Hi Joe,
On Mon, Dec 12, 2011 at 03:44:53PM -0800, Joe Perches wrote: > On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > > The test not [val1] or not [val2] always evaluates to true > > Hey Jamie and Roel > > Looking at drivers with: > > $ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers > > drivers/crypto/picoxcell_crypto.c: if ((len != AES_KEYSIZE_128 || len != AES_KEYSIZE_256) && > drivers/crypto/picoxcell_crypto.c: } else if ((len != AES_KEYSIZE_128 || len != AES_KEYSIZE_256) && > > Most likely these should be && not ||.
Yup, the original code was incorrect. Patch to follow. Thanks Joe!
Jamie
| |