Messages in this thread | | | Subject | drivers/dma/sirf-dma.c: boolean and / or confusion | From | Joe Perches <> | Date | Mon, 12 Dec 2011 16:14:23 -0800 |
| |
On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > The test not [val1] or not [val2] always evaluates to true
Looking at drivers with:
$ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\)\s*\|\|\s*\(\s*\1\s*\!\=" drivers
drivers/dma/sirf-dma.c: if ((xt->dir != DMA_MEM_TO_DEV) || (xt->dir != DMA_DEV_TO_MEM)) {
Likely the || should be &&
| |