lkml.org 
[lkml]   [2011]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] IB/qib: Use kcalloc instead of kzalloc to allocate array
    From
    Date
    The advantage of kcalloc is, that will prevent integer overflows which could
    result from the multiplication of number of elements and size and it is also
    a bit nicer to read.

    The semantic patch that makes this change is available
    in https://lkml.org/lkml/2011/11/25/107

    Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
    ---

    diff -u -p a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
    --- a/drivers/infiniband/hw/qib/qib_init.c 2011-11-13 11:07:26.730159415 +0100
    +++ b/drivers/infiniband/hw/qib/qib_init.c 2011-11-28 19:51:23.644920442 +0100
    @@ -116,7 +116,7 @@ int qib_create_ctxts(struct qib_devdata
    * Allocate full ctxtcnt array, rather than just cfgctxts, because
    * cleanup iterates across all possible ctxts.
    */
    - dd->rcd = kzalloc(sizeof(*dd->rcd) * dd->ctxtcnt, GFP_KERNEL);
    + dd->rcd = kcalloc(dd->ctxtcnt, sizeof(*dd->rcd), GFP_KERNEL);
    if (!dd->rcd) {
    qib_dev_err(dd, "Unable to allocate ctxtdata array, "
    "failing\n");
    @@ -1435,9 +1435,8 @@ int qib_setup_eagerbufs(struct qib_ctxtd
    egrperchunk = rcd->rcvegrbufs_perchunk;
    size = rcd->rcvegrbuf_size;
    if (!rcd->rcvegrbuf) {
    - rcd->rcvegrbuf =
    - kzalloc(chunk * sizeof(rcd->rcvegrbuf[0]),
    - GFP_KERNEL);
    + rcd->rcvegrbuf = kcalloc(chunk, sizeof(rcd->rcvegrbuf[0]),
    + GFP_KERNEL);
    if (!rcd->rcvegrbuf)
    goto bail;
    }

    \
     
     \ /
      Last update: 2011-12-10 13:53    [W:0.020 / U:0.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site