Messages in this thread | | | Date | Thu, 24 Nov 2011 12:33:03 +0530 | From | Srikar Dronamraju <> | Subject | Re: Fwd: uprobes: register/unregister probes. |
| |
> On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote: > > +int register_uprobe(struct inode *inode, loff_t offset, > > + struct uprobe_consumer *consumer) > > +{ > > + struct uprobe *uprobe; > > + int ret = -EINVAL; > > + > > + if (!consumer || consumer->next) > > + return ret; > > + > > + inode = igrab(inode); > > So why are you dealing with !consumer but not with !inode? and why > does > it make sense to allow !consumer at all? >
I am not sure if I got your comment correctly.
I do check for inode just after the igrab.
I am actually not dealing with !consumer. If the consumer is NULL, then we dont have any handler to run so why would we want to register such a probe?
Also if consumer->next is Non-NULL, that means that this consumer was already used. Reusing the consumer, can result in consumers list getting broken into two.
If you meant something else please clarify.
-- Thanks and Regards Srikar
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |