[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 5/7] regmap: Check if a register is writable instead of readable in regcache_read
    On 11/16/2011 06:12 PM, Mark Brown wrote:
    > On Wed, Nov 16, 2011 at 06:09:06PM +0100, Lars-Peter Clausen wrote:
    >> On 11/16/2011 05:56 PM, Mark Brown wrote:
    >>> No, really - just do something legible and robust. For example, teach
    >>> regmap_readable() about the cache.
    >> Doesn't make much sense. We call regmap_readable from regcache_read, which
    >> is only called if we use a cache. So if we let regmap_readable return true
    >> in case we use a cache it will always be true in regcache_read and we can
    >> drop the check entirely.
    > We should at least check that we actually have a cached value there -
    > the cache is sparse after all.

    That's what the cache already does today, you recently change the rbtree
    implementation to return -ENOENT if there is no cached value.

     \ /
      Last update: 2011-11-16 18:19    [W:0.021 / U:67.976 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site