Messages in this thread | | | Date | Tue, 15 Nov 2011 00:37:33 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH] net/packet: remove dead code and unneeded variable from prb_setup_retire_blk_timer() |
| |
On Mon, 14 Nov 2011, Ryan Mallon wrote:
> On 14/11/11 08:55, Jesper Juhl wrote: > > > We test for 'tx_ring' being != zero and BUG() if that's the case. So after > > that check there is no way that 'tx_ring' could be anything _but_ zero, so > > testing it again is just dead code. Once that dead code is removed, the > > 'pkc' local variable becomes entirely redundant, so remove that as well. > > > What if CONFIG_BUG=n? >
Arrgh, I didn't consider that (should have, but didn't).. In that case we'll have #define BUG() do {} while(0) which is not going to work all that peachy with my change...
David: You may want to pass on this one. I obviously didn't think it through properly - sorry :-(
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |