[lkml]   [2011]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] net/packet: remove dead code and unneeded variable from prb_setup_retire_blk_timer()
    On 15/11/11 10:37, Jesper Juhl wrote:

    > On Mon, 14 Nov 2011, Ryan Mallon wrote:
    >> On 14/11/11 08:55, Jesper Juhl wrote:
    >>> We test for 'tx_ring' being != zero and BUG() if that's the case. So after
    >>> that check there is no way that 'tx_ring' could be anything _but_ zero, so
    >>> testing it again is just dead code. Once that dead code is removed, the
    >>> 'pkc' local variable becomes entirely redundant, so remove that as well.
    >> What if CONFIG_BUG=n?
    > Arrgh, I didn't consider that (should have, but didn't).. In that case
    > we'll have
    > #define BUG() do {} while(0)
    > which is not going to work all that peachy with my change...
    > David: You may want to pass on this one. I obviously didn't think it
    > through properly - sorry :-(

    It's something I've never been entirely clear on. How are you meant to
    handle something which really is a fatal bug if CONFIG_BUG=n?

    I think there are several places in the kernel where the expectation is
    that BUG() causes a panic that probably don't behave nicely at all
    (though I guess that might be the expected behaviour) if CONFIG_BUG=n.


     \ /
      Last update: 2011-11-15 00:41    [W:0.020 / U:0.804 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site