lkml.org 
[lkml]   [2011]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] USB: Realtek cr: Use kmemdup rather than duplicating its implementation
From
Date
Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
--- a/drivers/usb/storage/realtek_cr.c 2011-11-07 19:38:15.850375635 +0100
+++ b/drivers/usb/storage/realtek_cr.c 2011-11-08 10:56:26.333926507 +0100
@@ -398,10 +398,9 @@ static int rts51x_write_mem(struct us_da
u8 cmnd[12] = { 0 };
u8 *buf;

- buf = kmalloc(len, GFP_NOIO);
+ buf = kmemdup(data, len, GFP_NOIO);
if (buf == NULL)
return USB_STOR_TRANSPORT_ERROR;
- memcpy(buf, data, len);

US_DEBUGP("%s, addr = 0x%x, len = %d\n", __func__, addr, len);




\
 
 \ /
  Last update: 2011-11-10 19:31    [W:0.031 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site