Messages in this thread | | | Date | Sat, 29 Oct 2011 17:29:41 +0200 | Subject | Re: [PATCH v2 4/6] mm: Only IPI CPUs to drain local pages if they exist | From | Gilad Ben-Yossef <> |
| |
On Fri, Oct 28, 2011 at 6:07 PM, Rik van Riel <riel@redhat.com> wrote: > On 10/23/2011 11:56 AM, Gilad Ben-Yossef wrote: >> >> Use a cpumask to track CPUs with per-cpu pages in any zone >> and only send an IPI requesting CPUs to drain these pages >> to the buddy allocator if they actually have pages. > >> +/* Which CPUs have per cpu pages */ >> +cpumask_var_t cpus_with_pcp; >> +static DEFINE_PER_CPU(unsigned long, total_cpu_pcp_count); > > Does the flushing happen so frequently that it is worth keeping this > state on a per-cpu basis, or would it be better to check each CPU's > pcp info and assemble a cpumask at flush time like done in patch 5? >
No, I don't believe it is frequent at all. I will try to re-work the patch as suggested.
Thanks, Gilad
>
> > -- > All rights reversed >
-- Gilad Ben-Yossef Chief Coffee Drinker gilad@benyossef.com Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com
"I've seen things you people wouldn't believe. Goto statements used to implement co-routines. I watched C structures being stored in registers. All those moments will be lost in time... like tears in rain... Time to die. " -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |