lkml.org 
[lkml]   [2011]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] blk-throttle: Free up policy node associated with deleted rule
On Thu, Oct 20, 2011 at 05:08:25PM -0400, Vivek Goyal wrote:
> If a rule is being deleted, free up associated policy node. Otherwise
> that memory is leaked.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

Hi Jens,

Do you see any issues with the two patches. Can you please consider these
for merging.

Thanks
Vivek

> ---
> block/blk-cgroup.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
> index b596e54..4ddf11f 100644
> --- a/block/blk-cgroup.c
> +++ b/block/blk-cgroup.c
> @@ -1085,6 +1085,7 @@ static int blkiocg_file_write(struct cgroup *cgrp, struct cftype *cft,
>
> if (blkio_delete_rule_command(newpn)) {
> blkio_policy_delete_node(pn);
> + kfree(pn);
> spin_unlock_irq(&blkcg->lock);
> goto update_io_group;
> }
> --
> 1.7.4.4


\
 
 \ /
  Last update: 2011-10-25 15:39    [W:0.225 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site