Messages in this thread | | | Date | Thu, 20 Oct 2011 14:11:40 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2] blk-throttle: Take blkcg->lock while traversing blkcg->policy_list |
| |
Hello,
On Thu, Oct 20, 2011 at 05:08:26PM -0400, Vivek Goyal wrote: > blkcg->policy_list is protected by blkcg->lock. Its not rcu protected > list. So even for readers, they need to take blkcg->lock. There are > few functions which were reading the list without taking lock. Fix it. > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
And yeap, some of rcu usages in cfq/iocg seem either incorrect or unnecessary. Trying to clean up that now too.
Thank you.
-- tejun
| |