Messages in this thread Patch in this message | | | Date | Wed, 12 Oct 2011 22:39:36 +0800 | Subject | [PATCH] mm/huge_memory: Clean up typo when copying user highpage | From | Hillf Danton <> |
| |
Hi Andrea
When copying user highpage, the PAGE_SHIFT in the third parameter is a typo, I think, and is replaced with PAGE_SIZE.
When configuring transparent hugepage, it depends on x86 and MMU. Would you please tippoint why other archs with MMU, say MIPS, are masked out?
Thanks
Signed-off-by: Hillf Danton <dhillf@gmail.com> ---
--- a/mm/huge_memory.c Sat Aug 13 11:45:14 2011 +++ b/mm/huge_memory.c Wed Oct 12 22:26:15 2011 @@ -829,7 +829,7 @@ static int do_huge_pmd_wp_page_fallback(
for (i = 0; i < HPAGE_PMD_NR; i++) { copy_user_highpage(pages[i], page + i, - haddr + PAGE_SHIFT*i, vma); + haddr + PAGE_SIZE * i, vma); __SetPageUptodate(pages[i]); cond_resched(); }
| |