lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build warnings after merge of the writeback tree
On Tue, Oct 11, 2011 at 05:27:36PM +0800, Stephen Rothwell wrote:
> Hi,
>
> On Tue, 11 Oct 2011 17:17:25 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:
> >
> > On Tue, Oct 11, 2011 at 04:57:04PM +0800, Stephen Rothwell wrote:
> > >
> > > After merging the writeback tree, today's linux-next build (powerpc
> > > allnoconfig) produced these warnings:
> > >
> > > mm/page-writeback.c: In function 'bdi_position_ratio':
> > > mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > > page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > >
> > > Introduced by commits 6c14ae1e92c7 ("writeback: dirty position control")
> > > and 8927f66c4ede ("writeback: dirty position control - bdi reserve area").
> >
> > Ah sorry! The below patch should fix it. Shall I update the original
> > commits in place, or append this patch as a new commit?
>
> That choice is up to you as the maintainer of that tree. Either works
> for me (appending is easier for you and me, and the warning is not a
> problem as far as bisection is concerned).

Got it!

> > Fix powerpc compile warnings
> >
> > mm/page-writeback.c: In function 'bdi_position_ratio':
> > mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> >
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
>
> If you do keep it separate, you could add a
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> above your SOB line.

OK!

Thanks,
Fengguang



\
 
 \ /
  Last update: 2011-10-11 11:35    [W:0.043 / U:7.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site