lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build warnings after merge of the writeback tree
Hi,

On Tue, 11 Oct 2011 17:17:25 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:
>
> On Tue, Oct 11, 2011 at 04:57:04PM +0800, Stephen Rothwell wrote:
> >
> > After merging the writeback tree, today's linux-next build (powerpc
> > allnoconfig) produced these warnings:
> >
> > mm/page-writeback.c: In function 'bdi_position_ratio':
> > mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> >
> > Introduced by commits 6c14ae1e92c7 ("writeback: dirty position control")
> > and 8927f66c4ede ("writeback: dirty position control - bdi reserve area").
>
> Ah sorry! The below patch should fix it. Shall I update the original
> commits in place, or append this patch as a new commit?

That choice is up to you as the maintainer of that tree. Either works
for me (appending is easier for you and me, and the warning is not a
problem as far as bisection is concerned).

> Fix powerpc compile warnings
>
> mm/page-writeback.c: In function 'bdi_position_ratio':
> mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

If you do keep it separate, you could add a

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

above your SOB line.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-10-11 11:29    [W:0.036 / U:5.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site