Messages in this thread | | | Date | Thu, 6 Jan 2011 19:47:49 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] trace event skb remove duplicate null-pointer check |
| |
On Thu, Jan 06, 2011 at 01:38:02PM -0500, Mathieu Desnoyers wrote: > * Frederic Weisbecker (fweisbec@gmail.com) wrote: > > On Thu, Jan 06, 2011 at 10:15:44AM -0800, David Miller wrote: > > > From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > > > Date: Thu, 6 Jan 2011 12:53:19 -0500 > > > > > > > The check for NULL skb in the kfree_skb trace event is a duplicate from the > > > > check already done in its only caller, kfree_skb(). Remove this duplicate check. > > > > > > > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > > > > Acked-by: Neil Horman <nhorman@tuxdriver.com> > > > > > > Acked-by: David S. Miller <davem@davemloft.net> > > > > May be you want to take that on the net tree? Looks like more appropriate. > > Of course this can go through the tracing tree as well. > > It might be easier to manage the TRACE_EVENT() reshaping (removal of semicolumn, > tp_assign, etc) I am preparing if, at this stage, we merge most of the > include/trace/event patches through a single tree (the tracing tree). Otherwise > we might end up with more commit cross-dependencies between the trees, and > increase the risk of conflicts.
Alright, let's take that on the tracing tree.
I'll apply them if Steve doesn't beat me at it.
Thanks.
| |