lkml.org 
[lkml]   [2011]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] trace event skb remove duplicate null-pointer check
From
From: Frederic Weisbecker <fweisbec@gmail.com>
Date: Thu, 6 Jan 2011 19:17:29 +0100

> On Thu, Jan 06, 2011 at 10:15:44AM -0800, David Miller wrote:
>> From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> Date: Thu, 6 Jan 2011 12:53:19 -0500
>>
>> > The check for NULL skb in the kfree_skb trace event is a duplicate from the
>> > check already done in its only caller, kfree_skb(). Remove this duplicate check.
>> >
>> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
>>
>> Acked-by: David S. Miller <davem@davemloft.net>
>
> May be you want to take that on the net tree? Looks like more appropriate.
> Of course this can go through the tracing tree as well.

You guys can take it in the tracing tree, this actually makes things
easier for me.


\
 
 \ /
  Last update: 2011-01-06 19:39    [W:0.037 / U:1.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site