lkml.org 
[lkml]   [2011]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 24/32] dlm: dlm workqueues aren't used in memory reclaim path
From
Date
Hi,

You already acked a patch to do this, which is in the DLM git tree,
waiting for the next merge window:

http://git.kernel.org/?p=linux/kernel/git/teigland/dlm.git;a=commitdiff;h=dcce240ead802d42b1e45ad2fcb2ed4a399cb255

Steve.

On Mon, 2011-01-03 at 14:49 +0100, Tejun Heo wrote:
> dlm isn't depended upon during memory reclaim and so are its two
> workqueues. Convert to alloc[_ordered]_workqueue() without
> WQ_MEM_RECLAIM. While at it, fix workqueue allocation failure
> handling. They return %NULL on failure not ERR_PTR() value.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Christine Caulfield <ccaulfie@redhat.com>
> Cc: David Teigland <teigland@redhat.com>
> Cc: cluster-devel@redhat.com
> ---
> Only compile tested. Please feel free to take it into the subsystem
> tree or simply ack - I'll route it through the wq tree.
>
> Thanks.
>
> fs/dlm/lowcomms.c | 19 ++++++++-----------
> 1 files changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 37a34c2..9aad7c0 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -1430,20 +1430,17 @@ static void work_stop(void)
>
> static int work_start(void)
> {
> - int error;
> - recv_workqueue = create_workqueue("dlm_recv");
> - error = IS_ERR(recv_workqueue);
> - if (error) {
> - log_print("can't start dlm_recv %d", error);
> - return error;
> + recv_workqueue = alloc_workqueue("dlm_recv", 0, 1);
> + if (!recv_workqueue) {
> + log_print("can't start dlm_recv");
> + return -ENOMEM;
> }
>
> - send_workqueue = create_singlethread_workqueue("dlm_send");
> - error = IS_ERR(send_workqueue);
> - if (error) {
> - log_print("can't start dlm_send %d", error);
> + send_workqueue = alloc_ordered_workqueue("dlm_send", 0);
> + if (!send_workqueue) {
> + log_print("can't start dlm_send");
> destroy_workqueue(recv_workqueue);
> - return error;
> + return -ENOMEM;
> }
>
> return 0;




\
 
 \ /
  Last update: 2011-01-03 14:59    [W:0.403 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site