lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH UPDATED 21/32] fs/aio: aio_wq isn't used in memory reclaim path
Date
Tejun Heo <tj@kernel.org> writes:

> aio_wq isn't used during memory reclaim. Convert to alloc_workqueue()
> without WQ_MEM_RECLAIM. It's possible to use system_wq but given that
> the number of work items is determined from userland and the work item
> may block, enforcing strict concurrency limit would be a good idea.
>
> Also, move fput_work to system_wq so that aio_wq is used soley to
> throttle the max concurrency of aio work items and fput_work doesn't
> interact with other work items.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Benjamin LaHaise <bcrl@kvack.org>
> Cc: Jeff Moyer <jmoyer@redhat.com>

You actually missed that CC. ;-)

> Cc: linux-aio@kvack.org
> ---
> Patch description updated to describe fput_work change. If there's no
> further objection, I'll push it through workqueue#for-2.6.39. Thanks.

Looks good to me, based on not changing existing semantics.

Acked-by: Jeff Moyer <jmoyer@redhat.com>

Cheers,
Jeff


\
 
 \ /
  Last update: 2011-01-26 17:33    [from the cache]
©2003-2011 Jasper Spaans