Messages in this thread Patch in this message | | | From | Simon Xu <> | Subject | [PATCH] ext2: reduce redundant check of '*options' | Date | Thu, 13 Jan 2011 20:39:22 +0800 |
| |
We don't need to check whether '*options' equals to ',' twice.
Signed-off-by: Simon Xu <xu.simon@oracle.com> --- fs/ext2/super.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 7731695..bd5b66b 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -377,13 +377,13 @@ static unsigned long get_sb_block(void **data) return 1; /* Default location */ options += 3; sb_block = simple_strtoul(options, &options, 0); - if (*options && *options != ',') { + if (*options == ',') { + options++; + } else if (*options) { printk("EXT2-fs: Invalid sb specification: %s\n", (char *) *data); return 1; } - if (*options == ',') - options++; *data = (void *) options; return sb_block; } -- 1.7.3.5
| |