Messages in this thread Patch in this message | | | From | Vasiliy Kulikov <> | Subject | [PATCH 9/9] staging: wlags49_h2: use free_netdev(netdev) instead of kfree() | Date | Tue, 28 Sep 2010 21:08:11 +0400 |
| |
Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
@@ struct net_device* dev; @@
-kfree(dev) +free_netdev(dev)
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> --- Compile tested.
drivers/staging/wlags49_h2/wl_netdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index e2a7ad0..954bece 100644 --- a/drivers/staging/wlags49_h2/wl_netdev.c +++ b/drivers/staging/wlags49_h2/wl_netdev.c @@ -1586,7 +1586,7 @@ void wl_wds_device_dealloc( struct wl_private *lp ) dev_wds->flags &= ~( IFF_UP | IFF_RUNNING ); } - kfree( dev_wds ); + free_netdev(dev_wds); lp->wds_port[count].dev = NULL; } } -- 1.7.0.4
| |