Messages in this thread | | | Date | Fri, 3 Sep 2010 11:28:26 +1000 | From | Greg Ungerer <> | Subject | Re: [PATCH 3/3] Fix M68K irqflags |
| |
Hi David,
David Howells wrote: > From: Greg Ungerer <gerg@snapgear.com>
Almost :-)
> arch/m68k/include/asm/entry_no.h | 2 - > arch/m68k/include/asm/irqflags.h | 76 +++++++++++++++++++++++++++++++++++ > arch/m68k/include/asm/system_mm.h | 25 ------------ > arch/m68k/include/asm/system_no.h | 57 -------------------------- > arch/m68knommu/kernel/asm-offsets.c | 2 - > include/asm-generic/hardirq.h | 1 > 6 files changed, 79 insertions(+), 84 deletions(-) > create mode 100644 arch/m68k/include/asm/irqflags.h [snip] > #endif /* _M68KNOMMU_SYSTEM_H */ > diff --git a/arch/m68knommu/kernel/asm-offsets.c b/arch/m68knommu/kernel/asm-offsets.c > index 9a8876f..2433502 100644 > --- a/arch/m68knommu/kernel/asm-offsets.c > +++ b/arch/m68knommu/kernel/asm-offsets.c > @@ -74,8 +74,6 @@ int main(void) > > DEFINE(PT_PTRACED, PT_PTRACED); > > - DEFINE(THREAD_SIZE, THREAD_SIZE); > -
This breaks final link due to missing THREAD_SIZE definition in head.S:
LD vmlinux arch/m68knommu/platform/coldfire/head.o: In function `_clear_bss': (.head.text+0xa4): undefined reference to `THREAD_SIZE'
Without that asm-offsets.c change it works on my ColdFire boards. I am happy with it:
Acked-by: Greg Ungerer <gerg@uclinux.org>
Thanks Greg
------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
| |