Messages in this thread | | | Date | Thu, 2 Sep 2010 15:54:38 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 2/3] M68K: Use CONFIG_MMU not __uClinux__ to select m68knommu contributions |
| |
On Thu, Sep 02, 2010 at 11:21:58AM +0100, David Howells wrote: > Use CONFIG_MMU not __uClinux__ to select m68knommu contributions as nothing in > the arch defines __uClinux__ for the build. > > This patch was achieved by running the following three commands: > > perl -pi -e 's/ifdef __uClinux__/ifndef CONFIG_MMU/' `find arch/m68k -name "*.[ch]"` > perl -pi -e 's/ifndef __uClinux__/ifdef CONFIG_MMU/' `find arch/m68k -name "*.[ch]"` > perl -pi -e 's!endif /[*] __uClinux__ [*]/!endif /* CONFIG_MMU */!' `find arch/m68k -name "*.[ch]"
Have you verified that this does not leak out to the userspace headers? We cannot use the CONFIG_ symbol to distingush between the two variants in userspace.
This was exactly the reason why __uClinux__ was used in the first place. But I hope Geert/Greg has fixed it up so all exported headers are the same so that this patch is OK.
At first look I think it is OK - but your changelog does not address this so wanted you to confirm this.
Sam
| |