lkml.org 
[lkml]   [2010]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ihex: Add support for CS:IP/EIP records
On Wed, Sep 15, 2010 at 02:27:44PM -0700, Andrew Morton wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> > + data32 = &record->data[0];
> > + *data32 = htonl(*data32);

> firmware/ihex2fw.c: In function 'process_ihex':
> firmware/ihex2fw.c:231: warning: assignment from incompatible pointer type

Which architecture are you using - my AMD64 system isn't noticing these
things for me?

> And afacit data[] isn't 32-bit aligned and I don't know that all
> architectures support htonl() against a misaligned pointer.

We're pretty much safe in userspace, if the hardware doesn't support it
then as far as I'm aware pretty much all OSs do a software fixup. This
isn't great for performance but works.

> I'll drop the patch.

OK, I'll spin it later today.


\
 
 \ /
  Last update: 2010-09-16 12:45    [W:0.061 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site