lkml.org 
[lkml]   [2010]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ihex: Add support for CS:IP/EIP records
On Sat, Sep 11, 2010 at 09:29:04AM +0100, David Woodhouse wrote:

> - Which firmware blobs that are *already* in the kernel would need this?
> Remember, we're not adding new crap to the kernel source tree; new
> firmware images get added to linux-firmware.git instead.

None to my knowledge, however I don't understand why this would be
relevant to adding new features to ihex2fw?

> - Why make the include_jump code optional? When would we ever *not* want
> to include such a record -- when does the input ihex file contain such
> a record that the kernel driver *must* not see because it can't cope
> with it?

Given that our binary ihex format discards all record type information I
would expect all existing users would be confused if they started seeing
these records so it seems safer to only generate them when required. It
seems likely that some ihex images will contain jump addresses generated
by their toolchain which do not need to be parsed since the address is
always the same (eg, the address the device uses when brought out of
reset), though none of those in the kernel tree currently seem to.


\
 
 \ /
  Last update: 2010-09-11 12:09    [from the cache]
©2003-2011 Jasper Spaans