Messages in this thread | | | Date | Mon, 23 Aug 2010 09:29:57 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support |
| |
Hi,
please break your lines at 80-characters. Also the [Hiremath, Vaibhav] is unnecessary.
On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote: >> don't you need some locking on the irq handler ? a mutex maybe ? Just >> wondering... >> >[Hiremath, Vaibhav] Yes definitely we do need locking here, I thought >of adding locking mechanism in subsequent patch, does it makes sense?
so you add a buggy patch and fix it later ? If you already know it's buggy, why not changing the patch that adds the bug ?
-- balbi
DefectiveByDesign.org
| |