lkml.org 
[lkml]   [2010]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
> Sent: Monday, August 23, 2010 12:00 PM
> To: Hiremath, Vaibhav
> Cc: Balbi Felipe (Nokia-MS/Helsinki); linux-kernel@vger.kernel.org;
> akpm@linux-foundation.org; byron.bbradley@gmail.com; linux-
> omap@vger.kernel.org
> Subject: Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support
>
> Hi,
>
> please break your lines at 80-characters.

Normally I do take care of this, but missed this time. I will be more careful in the future.

> Also the [Hiremath, Vaibhav]
> is unnecessary.
>
> On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote:
> >> don't you need some locking on the irq handler ? a mutex maybe ? Just
> >> wondering...
> >>
> >[Hiremath, Vaibhav] Yes definitely we do need locking here, I thought
> >of adding locking mechanism in subsequent patch, does it makes sense?
>
> so you add a buggy patch and fix it later ? If you already know it's
> buggy, why not changing the patch that adds the bug ?
>
[Hiremath, Vaibhav] Nothing to argue here, I have to admit/accept and fix this.

Thanks,
Vaibhav

> --
> balbi
>
> DefectiveByDesign.org


\
 
 \ /
  Last update: 2010-08-23 12:37    [W:0.040 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site