lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used
    Justin P. Mattock <justinmattock@gmail.com> wrote:
    > The below fixes a warning message generated by GCC
    > CC [M] drivers/crypto/hifn_795x.o
    > drivers/crypto/hifn_795x.c: In function 'hifn_flush':
    > drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
    > drivers/crypto/hifn_795x.c: In function 'hifn_process_queue':
    > drivers/crypto/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used
    >
    > Please have a look, and let me know if this is legit or not.
    >
    > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
    >
    > ---
    > drivers/crypto/hifn_795x.c | 10 ++++++++++
    > 1 files changed, 10 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
    > index 16fce3a..e7aa4dc 100644
    > --- a/drivers/crypto/hifn_795x.c
    > +++ b/drivers/crypto/hifn_795x.c
    > @@ -2036,6 +2036,11 @@ static void hifn_flush(struct hifn_device *dev)
    > spin_lock_irqsave(&dev->lock, flags);
    > while ((async_req = crypto_dequeue_request(&dev->queue))) {
    > ctx = crypto_tfm_ctx(async_req->tfm);
    > + if (ctx) {
    > + dprintk("%s: Flushing shash. %s\n",
    > + dev->name, ctx);
    > + return;
    > + }

    This certainly does not look right! Returning with IRQs disabled
    is considered to be rude.

    I believe the right answer is to delete the line initialising ctx.

    Thanks,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2010-07-06 09:07    [W:0.023 / U:29.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site