lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used
On 07/06/2010 12:03 AM, Herbert Xu wrote:
> Justin P. Mattock<justinmattock@gmail.com> wrote:
>> The below fixes a warning message generated by GCC
>> CC [M] drivers/crypto/hifn_795x.o
>> drivers/crypto/hifn_795x.c: In function 'hifn_flush':
>> drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
>> drivers/crypto/hifn_795x.c: In function 'hifn_process_queue':
>> drivers/crypto/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used
>>
>> Please have a look, and let me know if this is legit or not.
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> drivers/crypto/hifn_795x.c | 10 ++++++++++
>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
>> index 16fce3a..e7aa4dc 100644
>> --- a/drivers/crypto/hifn_795x.c
>> +++ b/drivers/crypto/hifn_795x.c
>> @@ -2036,6 +2036,11 @@ static void hifn_flush(struct hifn_device *dev)
>> spin_lock_irqsave(&dev->lock, flags);
>> while ((async_req = crypto_dequeue_request(&dev->queue))) {
>> ctx = crypto_tfm_ctx(async_req->tfm);
>> + if (ctx) {
>> + dprintk("%s: Flushing shash. %s\n",
>> + dev->name, ctx);
>> + return;
>> + }
>
> This certainly does not look right! Returning with IRQs disabled
> is considered to be rude.

Well, I certainly did not want to be rude..(searching for the right
return etc.. when a function returns null gives not vary much results)

>
> I believe the right answer is to delete the line initialising ctx.
>
> Thanks,


o.k. then I'll resend with delete the line initialising ctx

Thanks for having a look..

Justin P. Mattock


\
 
 \ /
  Last update: 2010-07-06 15:49    [W:0.039 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site