Messages in this thread | | | From | Mike Frysinger <> | Date | Thu, 29 Jul 2010 12:24:59 -0400 | Subject | Re: [Uclinux-dist-devel] [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level> |
| |
On Wed, Jul 28, 2010 at 11:36, Mike Frysinger wrote: > On Wed, Jul 28, 2010 at 06:00, Joe Perches wrote: >> On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote: >>> On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote: >>> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" >>> > total: 2 errors, 25 warnings, 1723 lines checked >>> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" >>> > total: 0 errors, 0 warnings, 1743 lines checked >>> i dislike the mixing of whitespace and useful changes >>> if they were split, and they worked, then i wouldnt have a problem with them >> >> Is that a nak or a dislike? > > if you arent going to bother fixing things, then i guess it's a NAK ;)
to be clear, i dont have a problem with the direction you're going with things, just the steps to get there. i dont like throwing up "NAK" at postings because that often sounds like a "f-you!" in my head. i'd rather suggest changes and then ACK the updated patch(es). -mike
| |