Messages in this thread | | | From | Mike Frysinger <> | Date | Wed, 28 Jul 2010 11:36:35 -0400 | Subject | Re: [Uclinux-dist-devel] [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level> |
| |
On Wed, Jul 28, 2010 at 06:00, Joe Perches wrote: > On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote: >> On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote: >> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" >> > total: 2 errors, 25 warnings, 1723 lines checked >> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" >> > total: 0 errors, 0 warnings, 1743 lines checked >> i dislike the mixing of whitespace and useful changes >> if they were split, and they worked, then i wouldnt have a problem with them > > Is that a nak or a dislike?
if you arent going to bother fixing things, then i guess it's a NAK ;)
> Also, is Michael Hennerich actually the maintainer for bfin_mac? > He had been listed as MAINTAINER for over a year but he hasn't > ever written or acked a patch for this file.
i dont know what log you're reading, but i see Michael making plenty of changes to this driver -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |