lkml.org 
[lkml]   [2010]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible
    On 06/15/2010 12:54 PM, Christoph Hellwig wrote:
    > On Tue, Jun 15, 2010 at 12:49:49PM -0400, Rik van Riel wrote:
    >> This is already in a filesystem. Why does ->writepage get
    >> called a second time? Shouldn't this have a gfp_mask
    >> without __GFP_FS set?
    >
    > Why would it? GFP_NOFS is not for all filesystem code, but only for
    > code where we can't re-enter the filesystem due to deadlock potential.

    Why? How about because you know the stack is not big enough
    to have the XFS call path on it twice? :)

    Isn't the whole purpose of this patch series to prevent writepage
    from being called by the VM, when invoked from a deep callstack
    like xfs writepage?

    That sounds a lot like simply wanting to not have GFP_FS...

    --
    All rights reversed


    \
     
     \ /
      Last update: 2010-06-15 21:17    [W:0.020 / U:29.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site