Messages in this thread | | | Date | Tue, 15 Jun 2010 12:54:23 -0400 | From | Christoph Hellwig <> | Subject | Re: [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible |
| |
On Tue, Jun 15, 2010 at 12:49:49PM -0400, Rik van Riel wrote: > This is already in a filesystem. Why does ->writepage get > called a second time? Shouldn't this have a gfp_mask > without __GFP_FS set?
Why would it? GFP_NOFS is not for all filesystem code, but only for code where we can't re-enter the filesystem due to deadlock potential.
Except for a few filesystems that have transactions open inside ->aio_write no one uses GFP_NOFS from that path.
| |