Messages in this thread | | | Date | Tue, 15 Jun 2010 17:22:10 +0100 | From | Jeremy Fitzhardinge <> | Subject | Re: [Xen-devel] [PATCH 06/12] Allow xen platform pci device to be compiled as a module |
| |
On 06/14/2010 10:20 PM, Konrad Rzeszutek Wilk wrote: >> -static inline unsigned int max_nr_grant_frames(void) >> +unsigned int gnttab_max_nr_grant_frames(void) >> { >> unsigned int xen_max = __max_nr_grant_frames(); >> >> @@ -444,6 +445,7 @@ static inline unsigned int max_nr_grant_frames(void) >> return boot_max_nr_grant_frames; >> return xen_max; >> } >> +EXPORT_SYMBOL_GPL(gnttab_max_nr_grant_frames); >> > Prefix the name with 'xen_' ? That is a mouthfull thought: > > Xen Grant Table Max Nr Grant Frames. How about 'xen_gnttab_max_frames' ? >
Unfortunately the gnttab API is generally lacking xen_ prefixes. It's better to keep this consistent, and then maybe sort them all out together.
J
| |