lkml.org 
[lkml]   [2010]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 06/12] Allow xen platform pci device to be compiled as a module
On 06/14/2010 10:20 PM, Konrad Rzeszutek Wilk wrote:
>> -static inline unsigned int max_nr_grant_frames(void)
>> +unsigned int gnttab_max_nr_grant_frames(void)
>> {
>> unsigned int xen_max = __max_nr_grant_frames();
>>
>> @@ -444,6 +445,7 @@ static inline unsigned int max_nr_grant_frames(void)
>> return boot_max_nr_grant_frames;
>> return xen_max;
>> }
>> +EXPORT_SYMBOL_GPL(gnttab_max_nr_grant_frames);
>>
> Prefix the name with 'xen_' ? That is a mouthfull thought:
>
> Xen Grant Table Max Nr Grant Frames. How about 'xen_gnttab_max_frames' ?
>

Unfortunately the gnttab API is generally lacking xen_ prefixes. It's
better to keep this consistent, and then maybe sort them all out together.

J



\
 
 \ /
  Last update: 2010-06-15 18:25    [W:0.164 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site